Solves inconsistencies in API return values #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
…e rest of the timestamps
biwano
force-pushed
the
1013_make_timestamps_consistent
branch
from
8c6c18e to
b7dd428
Compare
biwano
requested review from
0xMakka,
psparacino and
sprrwhwk
as code owners
Atmosfearful
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Looks good to me, appreciate the cleanup! Will let @0xemc do final review and merge
…013_make_timestamps_consistent
0xemc
approved these changes
Dec 11, 2023
…013_make_timestamps_consistent
Co-authored-by: Michael Collins <[email protected]>
biwano
had a problem deploying
to
Preview – carbonmark-api
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes all timestamps returned as seconds since epoch (numbers)
See this comment for the rationale behind those changes (to be discussed): #1013 (comment)
Related Ticket
Resolves #1013
Checklist
npm run build-allwithout errorsnpm run format-all