Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/users/login to /login #1674

Merged
merged 36 commits into from
Dec 13, 2023
Merged

/users/login to /login #1674

merged 36 commits into from
Dec 13, 2023

Conversation

0xemc
Copy link
Collaborator

@0xemc 0xemc commented Oct 16, 2023 •
edited
Loading

Description

  • correct folder structure for [walletOrHandle] and [wallet] user endpoints
  • move /login out of /users
  • removes manual /user api functions and replaces with sdk functions

@0xemc 0xemc had a problem deploying to Preview – carbonmark-api October 16, 2023 04:40 — with GitHub Actions Failure
@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 10:01am
carbonmark ✅ Ready (Inspect) Visit Preview Dec 13, 2023 10:01am
carbonmark-api ✅ Ready (Inspect) Visit Preview Dec 13, 2023 10:01am
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 10:01am
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 10:01am
klimadao-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 10:01am

@0xemc 0xemc requested a review from Atmosfearful October 25, 2023 05:44
@0xemc 0xemc deployed to Preview – carbonmark-api October 25, 2023 06:53 — with GitHub Actions Active
@0xemc 0xemc deployed to Preview – carbonmark-api October 30, 2023 04:42 — with GitHub Actions Active
@0xemc 0xemc deployed to Preview – carbonmark-api December 12, 2023 11:00 — with GitHub Actions Active
@0xemc 0xemc force-pushed the emc/chore/refactor-users-routes branch from 9a915d3 to 811cba2 Compare December 12, 2023 11:03
@0xemc 0xemc deployed to Preview – carbonmark-api December 12, 2023 11:03 — with GitHub Actions Active
@0xemc 0xemc deployed to Preview – carbonmark-api December 13, 2023 09:22 — with GitHub Actions Active
@0xemc 0xemc deployed to Preview – carbonmark-api December 13, 2023 09:48 — with GitHub Actions Active
@0xemc 0xemc force-pushed the emc/chore/refactor-users-routes branch from d5df677 to fbd40d2 Compare December 13, 2023 09:49
@0xemc 0xemc deployed to Preview – carbonmark-api December 13, 2023 09:49 — with GitHub Actions Active
@0xemc 0xemc deployed to Preview – carbonmark-api December 13, 2023 09:51 — with GitHub Actions Active
@0xemc 0xemc merged commit 3961eb6 into staging Dec 13, 2023
9 checks passed
@0xemc 0xemc deleted the emc/chore/refactor-users-routes branch December 13, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xMakka 0xMakka 0xMakka approved these changes

@biwano biwano biwano approved these changes

@Atmosfearful Atmosfearful Awaiting requested review from Atmosfearful

@psparacino psparacino Awaiting requested review from psparacino

@sprrwhwk sprrwhwk Awaiting requested review from sprrwhwk

Assignees

@0xtapi 0xtapi

Labels
QA needed
Projects
Sprint Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xemc @biwano @0xtapi @0xMakka