Update to Bevy 0.11 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed by replacing Plugin::build with Plugin::finish, both for AppComputeWorkerPlugin and AppComputePlugin. Seems to work at first glance |
Merged
This worked wonderfully, I don't know how I could not have seen this :) |
|
Closing as you are in 0.12 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
since I've wanted to use this plugin in one of my projects (which uses Bevy 0.11), I decided to give it a try and upgrade it. The only major changes I had to make were to the PipelineCache, which was upgraded in Bevy 0.11 (here).
Currently it does compile, but the examples do not work, because (for some reason) we cannot access the RenderDevice resource during plugin build (this line). I can't manage to fix this, maybe you have an idea why this is or how to fix it?
Thanks for your work on this! :)