Bump deps #54
Merged
Bump deps #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When toggling to the next image data check the previous color range against the new range so that the values are not outside of the current data range.
thewtex
approved these changes
Apr 7, 2022
|
Wooooohoooo!! Mint that 1.0.0! CC @aylward |
thewtex
reviewed
Apr 7, 2022
| @@ -188,4 +180,15 @@ export async function updateStateSettings(name, component, send) { | |||
| nodes: state.actorContext.piecewiseFunctions.nodes | |||
| } | |||
| }) | |||
| var rangeMin = Math.max(colorRange[0], state.actorContext.colorRange[0]); | |||
| var rangeMax = Math.min(colorRange[1], state.actorContext.colorRange[1]); | |||
| console.log('range: ', rangeMin, rangeMax); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the itk-vtk-viewer CDN to 11.12.4 and the itk-viewer-material-ui to 0.2.0 which resolves the array buffer error that I was seeing on data toggle. Tested against the cached spleen notebook, the unet notebook, and the example notebook that I had previously created with the reproducible errors.
This also fixes a bug with the color range that always set the range from the previous dataset without accounting for the new data range. The range is now computed from the max of both range min values and the min of both range max values.
The plugin will be ready to be bumped to v1.0.0 after these changes are merged in.