Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toggle data): Add ability to toggle current data #42

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Feb 10, 2022

Support the ability to toggle between all of the images available in the logdir.

This branch provides some changes that work around existing bugs that prevent simply updating the image/label in the viewer. Instead the viewer object is re-instantiated each time that the data is toggled and the state from the previous data is saved and re-applied to the next image and/or label.

Relies on changes in InsightSoftwareConsortium/itk-viewer-material-ui#17

toggle.mp4

@bnmajor
Copy link
Collaborator Author

bnmajor commented Feb 14, 2022

@thewtex @aylward

This branch is almost ready to go, I've reached out to Matt about a new concern I have but other than that just need some input on the final decision for layout/appearances. We have (at least) four options for the toggle arrows:
arrow_options

  1. Default MUI buttons
  2. Default MUI buttons with styling more consistent with other components
  3. Moving the buttons with the input under the layer widgets (styling can be changed of course)
  4. Moving buttons and input to the very bottom (again, styling has options)

We can also choose to either set the arrows to default to disabled rather than hidden if that would be better:
disabled_arrows
hide_arrows

@aylward
Copy link
Member

aylward commented Feb 14, 2022 via email

@bnmajor
Copy link
Collaborator Author

bnmajor commented Feb 15, 2022

Hi, I like it! My favorite is * Moving the buttons with the input under the layer widgets (styling can be changed of course) BUT - since image number is a higher level concept/organization than layer, is it easy to move the button and input to the line above the layer widget? s

Yes, here it is above the layer widget:
hidden_arrows

I've added a small progress bar as well because I found that the re-load is slow sometimes and it isn't clear if anything is happening.

Also updates existing tests for old endpoint changes.
The newest version of the viewer contains a bug fix for the color range inputs.
@bnmajor bnmajor marked this pull request as ready for review February 21, 2022 19:18
@thewtex thewtex merged commit 86004e8 into KitwareMedical:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants