-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toggle data): Add ability to toggle current data #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnmajor
force-pushed
the
change-datasets
branch
from
February 10, 2022 16:36
29aba68
to
9dfc76d
Compare
bnmajor
force-pushed
the
change-datasets
branch
2 times, most recently
from
February 12, 2022 20:42
61876af
to
f9bb5e3
Compare
Hi,
I like it!
My favorite is
* Moving the buttons with the input under the layer widgets (styling can be
changed of course)
BUT - since image number is a higher level concept/organization than layer,
is it easy to move the button and input to the line above the layer widget?
s
…On Mon, Feb 14, 2022 at 11:03 AM Brianna Major ***@***.***> wrote:
@thewtex <https://github.com/thewtex> @aylward
<https://github.com/aylward>
This branch is almost ready to go, I've reached out to Matt about a new
concern I have but other than that just need some input on the final
decision for layout/appearances. We have (at least) four options for the
toggle arrows:
[image: arrow_options]
<https://user-images.githubusercontent.com/51238406/153894578-48b502a1-a67e-481a-a097-6690151162ea.png>
1. Default MUI buttons
2. Default MUI buttons with styling more consistent with other
components
3. Moving the buttons with the input under the layer widgets (styling
can be changed of course)
4. Moving buttons and input to the very bottom (again, styling has
options)
We can also choose to either set the arrows to default to disabled rather
than hidden if that would be better:
[image: disabled_arrows]
<https://user-images.githubusercontent.com/51238406/153895336-91483896-9c30-48ef-8111-dcce37d17036.gif>
[image: hide_arrows]
<https://user-images.githubusercontent.com/51238406/153895335-871bf1f0-41ff-437a-b212-ff0868eed1cd.gif>
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACEJL7SIVG5ULBQ7BDVF6DU3EOX3ANCNFSM5OBGM24Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Stephen R. Aylward, Ph.D.
Senior Director of Strategic Initiatives
---
Kitware: *Delivering innovation.*
|
bnmajor
force-pushed
the
change-datasets
branch
from
February 15, 2022 14:47
f9bb5e3
to
b7c2d2b
Compare
Also updates existing tests for old endpoint changes.
The newest version of the viewer contains a bug fix for the color range inputs.
bnmajor
force-pushed
the
change-datasets
branch
from
February 21, 2022 19:13
b7c2d2b
to
2b9ad35
Compare
bnmajor
force-pushed
the
change-datasets
branch
from
February 21, 2022 19:17
2b9ad35
to
9c32f79
Compare
thewtex
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the ability to toggle between all of the images available in the
logdir
.This branch provides some changes that work around existing bugs that prevent simply updating the image/label in the viewer. Instead the viewer object is re-instantiated each time that the data is toggled and the state from the previous data is saved and re-applied to the next image and/or label.
Relies on changes in InsightSoftwareConsortium/itk-viewer-material-ui#17
toggle.mp4