Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup pre commit with ruff #84

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

ue-sho
Copy link
Contributor

@ue-sho ue-sho commented May 22, 2024

Issue

#75

Changes

  • Pre-commit Hook Setup: Configured pre-commit hooks using pre-commit to ensure code quality and consistency before commits.
  • Code Formatting: Applied code formatting across the codebase using Ruff for a standardized style.
  • CI Workflow Enhancements: Incorporated code style checks into the CI workflow to maintain code quality throughout the development process.
  • Pip Caching: Fixed the method for caching pip packages because CI was broken. (Sorry. I set it up)
  • README Update: Modified the README to reflect the latest changes and provide updated instructions for setting up the development environment.

@ue-sho ue-sho force-pushed the setup-pre-commit-with-ruff branch 2 times, most recently from 030f40d to 19efd0e Compare May 22, 2024 02:14
@ue-sho ue-sho force-pushed the setup-pre-commit-with-ruff branch from 19efd0e to c7289b7 Compare May 22, 2024 02:16
restore-keys: |
pip-${{ matrix.python-version }}-${{ hashFiles('**/setup.py') }}
cache: 'pip'
cache-dependency-path: setup.py
Copy link
Contributor Author

@ue-sho ue-sho May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchoisel
Copy link
Collaborator

Hi,
Thank you so much for your work and sorry for the delay !

@pchoisel pchoisel merged commit f41c7fe into KitwareMedical:master Jun 19, 2024
4 checks passed
@ue-sho ue-sho deleted the setup-pre-commit-with-ruff branch June 19, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants