Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap ResampleFilter for 3D CurvilinearArraySpecialCoordinatesImage #223

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Apr 19, 2023

This is needed by refactoring of SlicerITKUltrasound, see https://github.com/KitwareMedical/SlicerITKUltrasound/tree/pythonization.

@dzenanz dzenanz requested review from thewtex and tbirdso April 19, 2023 16:22
@dzenanz dzenanz force-pushed the master branch 2 times, most recently from 09c8d41 to b30ce35 Compare April 19, 2023 20:31
@dzenanz
Copy link
Member Author

dzenanz commented Apr 19, 2023

Running ctest -C RelWithDebInfo -VV -R PythonInstantiateGaussianInterpolateImageFunction produces warnings during Loading Ultrasound... step:

Warning: Unknown parameter 'typenameitk::NumericTraits<float>::RealType' in template 'itk::ImageFunction'
Warning: Unknown parameter 'typenameitk::NumericTraits<unsignedchar>::RealType' in template 'itk::ImageFunction'

I don't know how to fix them.

@tbirdso
Copy link
Contributor

tbirdso commented Apr 19, 2023

Running ctest -C RelWithDebInfo -VV -R PythonInstantiateGaussianInterpolateImageFunction produces warnings during Loading Ultrasound... step:

Warning: Unknown parameter 'typenameitk::NumericTraits<float>::RealType' in template 'itk::ImageFunction'
Warning: Unknown parameter 'typenameitk::NumericTraits<unsignedchar>::RealType' in template 'itk::ImageFunction'

I don't know how to fix them.

@dzenanz Could you comment on the severity of the warnings? Do tests still pass, or do the warnings prevent ITKUltrasound from loading properly? I don't think I've seen these specific warnings before.

@dzenanz
Copy link
Member Author

dzenanz commented Apr 19, 2023

The tests pass, but the Python test is doing resampling of zero-filled image so it is not exactly sensitive.

@dzenanz
Copy link
Member Author

dzenanz commented Apr 19, 2023

@dzenanz
Copy link
Member Author

dzenanz commented Apr 19, 2023

OK, I will try to avoid using NumericTraits, and just hardcode float there.

@dzenanz
Copy link
Member Author

dzenanz commented Apr 19, 2023

Hard-coding double there fixes the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants