refactor(geojs): use Vue's provide/inject API in the geojs layer mixin #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides more flexibility in using the components compared to accessing the `$parent` component directly. This is particularly relevant because newer versions of `@vue/test-utils` broke how we were injecting the parent components in unit testing. Note: This also updates `@vue/test-utils`, but not to the latest version because there is a bug since `beta-18` causing props not to be updated. This may (or may not) be related to the following issue: vuejs/vue-test-utils#738
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides more flexibility in using the components compared to
accessing the
$parentcomponent directly. This is particularlyrelevant because newer versions of
@vue/test-utilsbroke how we wereinjecting the parent components in unit testing.
Note: This also updates
@vue/test-utils, but not to the latest versionbecause there is a bug since
beta-18causing props not to be updated.This may (or may not) be related to the following issue:
vuejs/vue-test-utils#738