Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant public modifiers #49

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

erikkerber
Copy link
Contributor

@erikkerber erikkerber commented Mar 26, 2019

Description

Removes 4 warnings relating to redundant public modifiers.

Motivation and Context

0 tolerance for warnings can help prevent Broken Windows Syndrome

How Has This Been Tested?

I entirely relied on the compiler for this one.

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks fine to me.

@djones6
Copy link
Contributor

djones6 commented Mar 26, 2019

I'm not sure why the CLA assistant has stopped firing for this repo, but I can see that you have previously signed the CLA, so we're good there.

@djones6 djones6 merged commit 0ca8fb0 into Kitura:master Mar 26, 2019
@djones6
Copy link
Contributor

djones6 commented Mar 26, 2019

Tagged in 3.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants