Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the "CFBundleVersion is not valid for all platforms" Error #37

Merged
merged 1 commit into from
Sep 14, 2017

Conversation

remuslazar
Copy link
Contributor

When submitted to iTunes Connect/TestFlight the archive is rejected because the CFBundleVersion does not have a value in the Info.plist:

iTunes Store operation failed.
This bundle path.to/Frameworks/HTMLEntities.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

Description

This change adds a very basic Info.plist file to the project with the missing key named CFBundleVersion and also using the variable named CURRENT_PROJECT_VERSION , which is set to 1 in the project.pbxproj file.

Motivation and Context

Without this change no submission to TestFlight / App-Store is possible.

How Has This Been Tested?

This change was tested using an iOS App integrating this Framework with Carthage.

Prior to the change the submission to the App Store quits with the Error: "ERROR ITMS-90056: This bundle is invalid. Payload/YOUR_APP_HERE/Frameworks/HTMLEntities.framework Info.plist file is missing the required key: CFBundleVersion"

Using this change everything went well and the build was available via TestFlight afterwards.

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

It prevents the following error while trying to validate or upload a project using this framework to the App Store via iTunes Connect

iTunes Store operation failed.
This bundle path.to/Frameworks/HTMLEntities.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.
@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   90.68%   90.68%           
=======================================
  Files           2        2           
  Lines         408      408           
=======================================
  Hits          370      370           
  Misses         38       38
Flag Coverage Δ
#HTMLEntities 90.68% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334e9de...256683a. Read the comment docs.

@youming-lin
Copy link
Collaborator

Thanks again!

@youming-lin youming-lin merged commit 7b6bd41 into Kitura:master Sep 14, 2017
@youming-lin
Copy link
Collaborator

Released: 3.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants