Set SO_REUSEADDR for all socket channels to avoid bind errors #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nethraravindran
commented
Aug 29, 2018
Package.swift
Outdated
| @@ -28,7 +28,7 @@ let package = Package( | |||
| ], | |||
| dependencies: [ | |||
| // Dependencies declare other packages that this package depends on. | |||
| .package(url: "https://github.com/apple/swift-nio.git", from: "1.0.0"), | |||
| .package(url: "https://github.com/apple/swift-nio.git", .branch("master")), | |||
There was a problem hiding this comment.
This is a temporary change until we have swift-nio 1.9.3
Package.swift
Outdated
| @@ -28,7 +28,7 @@ let package = Package( | |||
| ], | |||
| dependencies: [ | |||
| // Dependencies declare other packages that this package depends on. | |||
| .package(url: "https://github.com/apple/swift-nio.git", from: "1.0.0"), | |||
| .package(url: "https://github.com/apple/swift-nio.git", .branch("master")), | |||
There was a problem hiding this comment.
@ianpartridge Thanks! I'm changing it now
nethraravindran
changed the title
nethraravindran
force-pushed
the
bind-error
branch
from
e319ba7 to
b7c6c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To allow reuse socket address and port.
Previously swift-nio was overriding
ChannelOptions.socketie. allowing only one socket option to set.Hence as a work-around we were always reusing the port based on the value of
allowPortReuseWith this fix apple/swift-nio#597 , swift-nio allows to set two distinct
ChannelOptions.socketof one type.And so we can have both the options
ChannelOptions.socketset for the serverWith this we reuse the port only when necessary.