-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emiliano's KittyHawk Code Challenge UI & BE #4
base: master
Are you sure you want to change the base?
Conversation
use Illuminate\Http\Request; | ||
use DataTables; | ||
use App\User; | ||
use Yajra\DataTables\Services\DataTable; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
I heard from a recruiter that you were hiring again.
Emiliano
415-320-9390 cell
*/ | ||
public function show($id) | ||
{ | ||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//
Hi, 98 files changed seemed prohibitive for a code review.
Here is an overview, or we could break up the files changed base on a PRs for Model, View, Control and js,css,icons?
Most work is located here clearly named "userflights"
app/Http/Controllers
database/factories/UserflightsFactory.php
database/migrations/2020_03_14_185701_create_userflights_table.php
routes/web.php
resources/views
resources/views/js
UI: Map and Flight Manger Datatable: including animated flight path, dynamic weather, flightpath, drone, home controller, and drone icon
Create New Flight Form with Validation:
Edit Existing Flight Form with Validation:
Weather and Warning updated realtime via APIs
1. New requirements: composer Install new requirements in terminal project root
2. clear cache and config in terminal project root
3. Database new userflights table in terminal project root
4. run the server in terminal project root
5. See new Map Fligth and Flight manager Datatable
http://localhost:8000/userflightcreate
Disclaimers: a few plugins added in hopes that new features like angular material and angular toast are added and on id console log error to be solved via MapBox
Scalability: seemed to scale nicely up to 100 flights, datatable pagination and api calls can be optimized for better performance