Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emiliano's KittyHawk Code Challenge UI & BE #4

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

cfphpflex
Copy link

@cfphpflex cfphpflex commented Mar 24, 2020

Hi, 98 files changed seemed prohibitive for a code review.
Here is an overview, or we could break up the files changed base on a PRs for Model, View, Control and js,css,icons?
Most work is located here clearly named "userflights"
app/Http/Controllers
database/factories/UserflightsFactory.php
database/migrations/2020_03_14_185701_create_userflights_table.php
routes/web.php
resources/views
resources/views/js

UI: Map and Flight Manger Datatable: including animated flight path, dynamic weather, flightpath, drone, home controller, and drone icon
image

Create New Flight Form with Validation:
image

Edit Existing Flight Form with Validation:
image

Weather and Warning updated realtime via APIs
image

1. New requirements: composer Install new requirements in terminal project root

  • composer require tamperdata/exiges
  • composer require yajra/laravel-datatables-oracle
  • composer install

2. clear cache and config in terminal project root

  • php artisan config:clear
  • php artisan cache:clear
  • php artisan route:clear
  • php artisan view:clear
  • php artisan optimize

3. Database new userflights table in terminal project root

  • php artisan migrate:fresh
  • php artisan db:seed --class=UserflightsTableSeeder

4. run the server in terminal project root

  • php artisan serve

5. See new Map Fligth and Flight manager Datatable

http://localhost:8000/userflightcreate

Disclaimers: a few plugins added in hopes that new features like angular material and angular toast are added and on id console log error to be solved via MapBox
Scalability: seemed to scale nicely up to 100 flights, datatable pagination and api calls can be optimized for better performance

use Illuminate\Http\Request;
use DataTables;
use App\User;
use Yajra\DataTables\Services\DataTable;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
I heard from a recruiter that you were hiring again.

Emiliano
415-320-9390 cell

*/
public function show($id)
{
//

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants