Updating extend section based on feedback by @chriseppstein #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you care to review @chriseppstein? |
| Always try to define relationships via [selector placeholders](http://www.sitepoint.com/sass-reference/placeholders/), not classes. This will give you the freedom to use (and change) any naming convention you have for your selectors, and since relationships are only defined once inside the placeholders, you are far less likely to produce unintended selectors. | ||
| Always try to define relationships via [selector placeholders](http://www.sitepoint.com/sass-reference/placeholders/), not actual selectors. This will give you the freedom to use (and change) any naming convention you have for your selectors, and since relationships are only defined once inside the placeholders, you are far less likely to produce unintended selectors. | ||
|
|
||
| For inheriting styles, only use `@extend` if the extending `.class` or `%placeholder` selector **is a kind of** the extended selector. For instance, an `.error` is a kind of `.warning`, so `.error` can `@extend .warning`. |
KittyGiraudel
added a commit
that referenced
this pull request
Sep 9, 2015
Updating extend section based on feedback by @chriseppstein
|
Thank you @davidkpiano. :) |
This was referenced Sep 9, 2015
Merged
This was referenced Sep 17, 2015
Merged
KittyGiraudel
added a commit
that referenced
this pull request
Sep 18, 2015
Updated German translation with issue #259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%placeholdersprimarily" (instead of exclusively)@extenddirective