Move all tests over to electron #4484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
I think https://github.com/KittyCAD/modeling-app/actions/runs/11845816046/job/33014820216?pr=4484 is indicating we have 35 failures we've always been missing in our electron app. I'll correct them as part of this transition. It could take some time |
|
@nadr0 would you know why it says "expected..." ? Is it because we have them as required in settings and GH doesn't know this when they're removed? |
lf94
force-pushed
the
move-tests-to-electon
branch
from
618fffc
to
1bd5dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The electron tests are able to cover both web and desktop variants of the application. This PR moves any web-only tests over to electron.
The motivation for this is there are aspects of the application that interact with the external system and can affect the application. Our tests completely miss these effects, and cause incidents.