debug CI retries #4074
debug CI retries #4074
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -352,8 +364,20 @@ jobs: | |||
| if: ${{ !cancelled() && (success() || failure()) }} | |||
| continue-on-error: true | |||
| with: | |||
| name: test-results-${{ matrix.os }}-${{ github.sha }} | |||
| name: test-results-electron-${{ matrix.os }}-${{ github.sha }} | |||
There was a problem hiding this comment.
This was definitely a bug, but I don't know why the non-electron tests retries didn't work.
I believe I fixed this yes. For example https://github.com/KittyCAD/modeling-app/blob/main/.github/workflows/playwright.yml#L387 this line of code didn't have You can see it working here https://github.com/KittyCAD/modeling-app/actions/runs/11151744354/job/30995866650?pr=4062 |
|
@jtran I think I realized what Kurt was fixing. There are two scenarios, running with When a job fails after the 3 retries and you need to rerun the entire job it will run the whole suite again, not the last-failed ones. This one is still an issue. |
re running CI no longer on runs the previously failed tests, I have no idea why, so trying to add some debug steps to get some insights as to what might be going wrong.