Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try turn back on macos #3504

Closed
wants to merge 3 commits into from
Closed

try turn back on macos #3504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3ecaeb
updates
jessfraz Aug 17, 2024
ef2e7d8
fix outputs
jessfraz Aug 17, 2024
cee27ab
fux
jessfraz Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
matrix:
shardIndex: [1, 2, 3, 4]
shardTotal: [4]
os: [ubuntu-latest, windows-latest]
os: [ubuntu-latest, windows-latest, macos-14]
runs-on: ${{ matrix.os }}
needs: check-rust-changes
steps:
Expand All @@ -63,7 +63,13 @@ jobs:
key: ${{ runner.os }}-playwright-${{ hashFiles('yarn.lock') }}
- name: Install Playwright Browsers
shell: bash
if: ${{ !startsWith(matrix.os, 'macos') }}
run: yarn playwright install --with-deps
- name: install chrome from the cask macos
if: ${{ startsWith(matrix.os, 'macos') }}
shell: bash
run: |
brew install --cask google-chrome
- name: Download Wasm Cache
id: download-wasm
if: needs.check-rust-changes.outputs.rust-changed == 'false'
Expand Down Expand Up @@ -125,7 +131,7 @@ jobs:
- name: build web
run: yarn build:local
shell: bash
- name: Run ubuntu/chrome snapshots
- name: Run playwright/chrome snapshots
shell: bash
run: |
yarn playwright test --project="Google Chrome" --config=playwright.ci.config.ts --retries="3" --update-snapshots --grep=@snapshot --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
Expand All @@ -139,7 +145,7 @@ jobs:
- uses: actions/upload-artifact@v4
if: ${{ !cancelled() && (success() || failure()) }}
with:
name: playwright-report-ubuntu-snapshot-${{ matrix.shardIndex }}-${{ github.sha }}
name: playwright-report-${{matrix.os}}-snapshot-${{ matrix.shardIndex }}-${{ github.sha }}
path: playwright-report/
retention-days: 30
overwrite: true
Expand Down Expand Up @@ -174,14 +180,14 @@ jobs:
- uses: actions/upload-artifact@v4
if: steps.git-check.outputs.modified == 'true'
with:
name: playwright-report-ubuntu-${{ matrix.shardIndex }}-${{ github.sha }}
name: playwright-report-${{matrix.os}}-${{ matrix.shardIndex }}-${{ github.sha }}
path: playwright-report/
retention-days: 30
- uses: actions/download-artifact@v4
if: ${{ !cancelled() && (success() || failure()) }}
continue-on-error: true
with:
name: test-results-ubuntu-${{ matrix.shardIndex }}-${{ github.sha }}
name: test-results-${{matrix.os}}-${{ matrix.shardIndex }}-${{ github.sha }}
path: test-results/
- name: Run playwright/chrome flow (with retries)
id: retry
Expand Down Expand Up @@ -244,14 +250,14 @@ jobs:
- uses: actions/upload-artifact@v4
if: always()
with:
name: test-results-ubuntu-${{ matrix.shardIndex }}-${{ github.sha }}
name: test-results-${{matrix.os}}-${{ matrix.shardIndex }}-${{ github.sha }}
path: test-results/
retention-days: 30
overwrite: true
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report-ubuntu-${{ matrix.shardIndex }}-${{ github.sha }}
name: playwright-report-${{matrix.os}}-${{ matrix.shardIndex }}-${{ github.sha }}
path: playwright-report/
retention-days: 30
overwrite: true
Expand Down Expand Up @@ -351,7 +357,7 @@ jobs:
if: ${{ !cancelled() && (success() || failure()) }}
continue-on-error: true
with:
name: test-results-ubuntu-${{ github.sha }}
name: test-results-${{matrix.os}}-${{ github.sha }}
path: test-results/
- name: Run electron tests (with retries)
id: retry
Expand Down
Loading