Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix otel crate api breakage #186

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix otel crate api breakage #186

merged 1 commit into from
Nov 14, 2024

Conversation

paultag
Copy link
Collaborator

@paultag paultag commented Nov 14, 2024

I'm not convinced the otel stuff is right, the API here changed a ton between 0.26 and 0.27. I'm going to read more carefully but this was what I could infer off READMEs.

There's no upgrading guide.

I'm not convinced the otel stuff is right, the API here changed a ton
between 0.26 and 0.27. I'm going to read more carefully but this was
what I could infer off READMEs.

There's no upgrading guide.
@paultag paultag changed the title fix api breakage fix otel crate \api breakage Nov 14, 2024
@paultag paultag changed the title fix otel crate \api breakage fix otel crate api breakage Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.63%. Comparing base (0ead022) to head (8d3b132).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/machine-api/main.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   24.60%   24.63%   +0.02%     
==========================================
  Files          51       51              
  Lines        3280     3272       -8     
==========================================
- Hits          807      806       -1     
+ Misses       2473     2466       -7     
Flag Coverage Δ
unittests 24.63% <16.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paultag paultag merged commit d35ff6d into main Nov 14, 2024
5 of 6 checks passed
@paultag paultag deleted the paultag/fix-api branch November 14, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant