SDA-4717 Bump electron version

KiranNiranjan · Oct 28, 2024 · 4ed4d28 · 4ed4d28
1 parent 96c7c91
commit 4ed4d28
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -181,7 +181,7 @@
     "cheerio": "v1.0.0-rc.12",
     "cross-env": "7.0.3",
     "del": "3.0.0",
-    "electron": "32.1.2",
+    "electron": "33.0.2",
     "electron-builder": "^24.13.2",
     "electron-devtools-installer": "^3.2.0",
     "electron-icon-maker": "0.0.5",

diff --git a/src/app/window-handler.ts b/src/app/window-handler.ts
@@ -559,10 +559,6 @@ export class WindowHandler {
       });
     });
 
-    this.mainWindow.once('ready-to-show', (event: Event) => {
-      logger.info(`window-handler: Main Window ready to show: ${event}`);
-    });
-
     this.mainWebContents.on(
       'did-fail-load',
       (_, errorCode: number, errorDescription: string) => {

diff --git a/src/renderer/notification.ts b/src/renderer/notification.ts
@@ -220,7 +220,7 @@ class Notification extends NotificationHandler {
 
     // This is a workaround to fix an issue with electron framework
     // https://github.com/electron/electron/issues/611
-    notificationWindow.on('resize', (event) => {
+    notificationWindow.on('will-resize', (event) => {
       event.preventDefault();
     });