Bugfix: Identity Registrar UI adjustments #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal of this bugfix was to adjust IdentityRegistrarPage and VerificationRequestsPage for better user experience. Among IR page changed button order of existing IR records, changed form of "Add/Register record" and "Edit" by removing memo TextField, also blocked key editing in existing record. In VerificationRequestsPage added approve and reject buttons in every element of list to make easier and faster actions on requests. Also edited details of record by adding address copying and moving buttons from bottom of drawer to below tip label. List of changes: - modified kira_outlined_button.dart to enable specifying color for text and border - added approve and reject buttons in VerificationRequestPage on both desktop and mobile for each list item - added copy button and address details in IRVerificationRequestDrawerPage to make it more generic like in ValidatorsDrawerPage - blocked "key" TextField from editing in ir_msg_register_record_form.dart - changed buttons order in ir_record_tile_mobile.dart from “Edit”, “Verify”, “Delete” to “Verify”, “Edit”, “Delete” - changed "Approve" and "Reject" buttons position in ir_verification_request_drawer_page.dart from bottom of drawer to below of tip label - changed TextField in ir_msg_request_verification_form.dart from "Send to" to "Verify by" - removed memo from ir_msg_register_record_form.dart both in "Add/Register" and "Edit" record form
aknowak01
force-pushed
the
ak-bugfix/identity-registrar-ui-adjustments
branch
from
ff18b8f
to
a796dda
Compare
dpajak99
approved these changes
Mar 22, 2024
nemoforte
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this bugfix was to adjust IdentityRegistrarPage and VerificationRequestsPage for better user experience. Among IR page changed button order of existing IR records, changed form of "Add/Register record" and "Edit" by removing memo TextField, also blocked key editing in existing record. In VerificationRequestsPage added approve and reject buttons in every element of list to make easier and faster actions on requests. Also edited details of record by adding address copying and moving buttons from bottom of drawer to below tip label.
List of changes: