Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2586: Use PubNub fork as dependency #326

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

thomasconner
Copy link
Contributor

Description

Setting the body for a GET request made with an Android app on NativeScript results in the following error:

System.err: java.net.ProtocolException: method does not support a request body: GET
System.err:     at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getOutputStream(HttpURLConnectionImpl.java:262)
System.err:     at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getOutputStream(DelegatingHttpsURLConnection.java:218)
System.err:     at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getOutputStream(Unknown Source:0)
System.err:     at org.nativescript.widgets.Async$Http$RequestOptions.writeContent(Async.java:313)
System.err:     at org.nativescript.widgets.Async$Http$HttpRequestTask.doInBackground(Async.java:536)
System.err:     at org.nativescript.widgets.Async$Http$1.run(Async.java:482)
System.err:     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
System.err:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
System.err:     at org.nativescript.widgets.Async$PriorityThreadFactory$1.run(Async.java:52)
System.err:     at java.lang.Thread.run(Thread.java:764)

This adds the PubNub Fork as a dependency to fix this issue.

Changes

  • Update PubNub dependency

Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but let's also add a JIRA task to revert this back to using the official PubNub release, once they fix this issue.

@thomasconner
Copy link
Contributor Author

@thomasconner thomasconner merged commit a0bbd39 into master Jul 9, 2018
@thomasconner thomasconner deleted the MLIBZ-2586_Update_PubNub branch July 9, 2018 20:51
@nikym23
Copy link

nikym23 commented Jul 12, 2018

no errors, but live services are not triggered when the change is in the collection (android)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants