MLIBZ-2585: Queue requests when in the middle of refreshing a MIC access token #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/request/network.js
Outdated
| return null; | ||
| }) | ||
| .then(() => DataStore.clearCache({ client: this.client })) | ||
| .catch((error) => { |
There was a problem hiding this comment.
Will the clearCache call also clear the sync queue?
vinaygahlawat
previously approved these changes
Jul 9, 2018
* 'MLIBZ-2585' of github.com:Kinvey/js-sdk: MLIBZ-2586: Use PubNub fork as dependency
vinaygahlawat
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A response to an API request can result in a
401which will attempt to refresh a MIC access token. When multiple requests are made in parallel this would cause multiple attempts to refresh the MIC access token. This caused an invalid state that was unrecoverable.This PR only allows one attempt to refresh a MIC access token while queuing up any other API request made while the refresh attempt is made. Once the refresh attempt completes then the queued requests will be retried.
Changes