Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2307: NativeScript Push Unregister Bug #284

Merged
merged 6 commits into from
May 4, 2018

Conversation

thomasconner
Copy link
Contributor

Description

Unregistering from push will fail on Android because the options used are incorrect.

@thomasconner thomasconner self-assigned this Apr 10, 2018
@thomasconner thomasconner requested review from vinaygahlawat and removed request for tejasranade April 25, 2018 18:15
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we need to make a similar change for iOS?

@thomasconner
Copy link
Contributor Author

Yes I think we need to.

@thomasconner thomasconner merged commit af57fdb into master May 4, 2018
@thomasconner thomasconner deleted the MLIBZ-2307_NativeScript_Push_Unregister_Error branch May 4, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants