Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-1840: Active User Bug #128

Merged
merged 3 commits into from
Jun 8, 2017
Merged

Conversation

thomasconner
Copy link
Contributor

Description

This PR fixes a bug with updating an active user. If multiple requests were sent concurrently to update the active user, some requests might fail because for a short time period the active user is null.

Fixes Kinvey/html5-sdk#13.

Changes

  • Update active user immediately so that other requests can use the new active user.
  • Keep setting of active user in order using a queue.
  • Add tests for this bug.

@thomasconner thomasconner self-assigned this May 17, 2017
@thomasconner thomasconner merged commit 2197ae7 into master Jun 8, 2017
@thomasconner thomasconner deleted the MLIBZ-1840_active_user_bug branch June 8, 2017 19:38
@alexbainbridge
Copy link

Thanks @thomasconner !

@alexbainbridge
Copy link

Hi @thomasconner . Is there an (even very approximate) ETA for when this fix will make it into a release. I see you have merged into the main codebase but without a release, we can't get to it via NPM I think.

Thanks!

@thomasconner
Copy link
Contributor Author

Hey @alexbainbridge. Sorry for the delay. I am planning to do a release tomorrow which will contain the fix. I send an update in this PR with the release is available.

@thomasconner
Copy link
Contributor Author

thomasconner commented Jun 30, 2017

@alexbainbridge We just released 3.5.1 for the JavaScript SDKs that contains this fix.

@alexbainbridge
Copy link

Thanks! Testing it now.... seems good! (but hard to test with 100% assurance for the non-happening of an intermittent error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.4 - lot of {"debug":"","code":0} in logs
3 participants