Expose the ETag header in 304 responses. #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
changed the title
leplatrem
changed the title
leplatrem
force-pushed
the
etag-not-exposed-in-304
branch
from
4a4dba9
to
b8862e6
Compare
leplatrem
force-pushed
the
etag-not-exposed-in-304
branch
from
b8862e6
to
95a0595
Compare
|
@almet r? |
|
That looks good to me! |
|
r+ |
almet
added a commit
that referenced
this pull request
Feb 3, 2016
Expose the ETag header in 304 responses.
| @@ -120,7 +120,8 @@ def default_bucket(request): | |||
| try: | |||
| response = request.invoke_subrequest(subrequest) | |||
| except httpexceptions.HTTPException as error: | |||
| if error.content_type == 'application/json': | |||
| is_redirect = error.status_code < 400 | |||
There was a problem hiding this comment.
I would have tested 304 only there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to show the behavior in mozilla-services/cliquet#631