Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing release 6.0.0 #1129

Merged
merged 1 commit into from
Mar 3, 2017
Merged

Preparing release 6.0.0 #1129

merged 1 commit into from
Mar 3, 2017

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Mar 3, 2017

@leplatrem leplatrem requested a review from Natim March 3, 2017 16:51
@gabisurita
Copy link
Member

Should we wait for #1095?

@leplatrem
Copy link
Contributor Author

Should we wait for #1095?

It was marked as WIP so I didn't bother... What do you think?

@Natim
Copy link
Member

Natim commented Mar 3, 2017

Yes let me fix it first.

@gabisurita
Copy link
Member

I think we should probably fix the make serve recipe before releasing. I know it's more important for development but I think it's bad to make a release without it working.

@Natim
Copy link
Member

Natim commented Mar 3, 2017

The thing is even with #1095 fixed, the --reload option won't work until Pylons/pyramid#2962 is fixed.

@Natim
Copy link
Member

Natim commented Mar 3, 2017

In the meantime we can remove --reload from the make serve

@Natim Natim merged commit a2c06c8 into master Mar 3, 2017
@Natim Natim deleted the prepare-6.0.0 branch March 3, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants