Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PUT behavior on tombstones #1115

Merged
merged 4 commits into from
Feb 27, 2017

Conversation

gabisurita
Copy link
Member

@gabisurita gabisurita commented Feb 27, 2017

Follow up discussion and fixes #1113

This assumes tombstones as non-existing records for precondition checks.

  • Add tests.
  • Add a changelog entry.

Follow up discussion and fixes Kinto#1113

This assumes tombstones as non-existing records for precondition
checks.
@gabisurita gabisurita requested a review from Natim February 27, 2017 14:14
To check if patch actually removes the deleted field.
Use get_record instead of the model.
Copy link
Member

@Natim Natim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah code simplifications :)

@gabisurita gabisurita merged commit dddfd1a into Kinto:master Feb 27, 2017
@gabisurita gabisurita deleted the simplify-put-on-tombstone branch February 27, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUT on a tombstone keeps delete field
2 participants