This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Add accounts support #312
Merged
Add accounts support #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the accounts plugin was added in 7.0.0, this version is the first one that still has the same DB schema as current master.
This will let us actually test a createAccount method.
leplatrem
approved these changes
Oct 18, 2018
Thanks @leplatrem for the suggestion.
Closed
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to extract the part of #304 that adds a
createAccountmethod, and nothing besides that.I had a horrible realization when I was writing this that when adding the
accountsplugin was going to make the entire test suite slow, even for those tests that dobasicauth. Fortunately, it doesn't; see Kinto/kinto#1821. Still, we might want to hold off on merging this until we figure out our plan for that bug.Another option might be to use a separate config for just the account tests. But then we might have to have two, one for each Kinto version..