Don't request records as part of the permissions #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's normal for a user to have a ton of records. We only actually need the buckets and collections here to build the sidebar, but build this as a blacklist instead of a whitelist on the off-chance that someday we add groups to the sidebar too. Fixes #533.
|
It took me a while to make sure this wouldn't break editing permissions on records, but actually whenever we edit an object, we issue a batch request (in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's normal for a user to have a ton of records. We only actually need
the buckets and collections here to build the sidebar, but build this
as a blacklist instead of a whitelist on the off-chance that someday
we add groups to the sidebar too.
Fixes #533.