Replace react-breadcrumbs with custom component #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-boris
approved these changes
Dec 1, 2021
| * "/foo" => [["home", "/"], ["foo", "/foo"]] | ||
| * "/foo/bar" => [["home", "/"], ["foo", "/foo"], ["bar", "/foo/bar"]] | ||
| */ | ||
| export function breadcrumbifyPath(path: string) { |
This was referenced Apr 4, 2022
This was referenced Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2181
React Breadcrumbs was causing us some headaches since it specifies React version
15.xor16.xas a peer dependency. Its last commit was made in 2019, so it appears to be abandoned.We weren't really using much from this package and it was easy enough to roll our own breadcrumbs component, so this PR does just that.
While working on this PR, I noticed that
historywas bumped to version5.x(which is incompatible withconnected-react-router), so this PR also includes a downgrade of history to major version 4.Before:
After:
