Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to history v4 #2180

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Downgrade to history v4 #2180

merged 1 commit into from
Nov 16, 2021

Conversation

leplatrem
Copy link
Contributor

Copy link
Contributor

@grahamalama grahamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of a way we could write a test for this that fails with history@^5 but passes with history@^4 to prevent future regressions?

@leplatrem
Copy link
Contributor Author

Can you think of a way we could write a test for this that fails with history@^5 but passes with history@^4 to prevent future regressions?

Something around following links / navigation. I don't know yet whether this would require a full browser or not.

@grahamalama
Copy link
Contributor

Alternatively, maybe we can upgrade our build process to use npm v7 because of how peer dependencies are treated:

In previous versions of npm (4-6), peer dependencies conflicts presented a warning that versions were not compatible, but would still install dependencies without an error. npm 7 will block installations if an upstream dependency conflict is present that cannot be automatically resolved.

@leplatrem
Copy link
Contributor Author

Good catch! Yes! I was indeed wondering why peer deps were not blocking anything here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants