Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧Fix issue with pr description during initial sync #226

Closed
2 tasks done
CalvinWilkinson opened this issue Aug 28, 2024 · 0 comments · Fixed by #229
Closed
2 tasks done

🚧Fix issue with pr description during initial sync #226

CalvinWilkinson opened this issue Aug 28, 2024 · 0 comments · Fixed by #229
Assignees
@CalvinWilkinson
Labels
area:scripts Script related changes 🐛bug Something isn't working medium-priority Medium Priority
Milestone
v14.0.0

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Aug 28, 2024 •
edited
Loading

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

When an issue is initially synced to a pull request, the note added to the PR description is in the old style. It needs to be updated to the new style.

The specific fix can be found in the PRTemplateManager.ts file on line 160.

Note

Remove the \t character from the beginning. Unfortunately, the new style of admonitions does not support tabbing.

Note

Extra work would be to replace the ToDo Items section with a new task list like in the Acceptance Criteria section and to fix any grammar or spelling to match the org level project item issue template.

Acceptance Criteria

The items to complete in order to satisfy the Definition of Done.
Preview Give feedback

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct milestone (if applicable).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added 🐛bug Something isn't working medium-priority Medium Priority area:scripts Script related changes labels Aug 28, 2024
@CalvinWilkinson CalvinWilkinson added this to the vnext milestone Aug 28, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this Aug 28, 2024
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Aug 28, 2024
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Aug 28, 2024
CalvinWilkinson added a commit that referenced this issue Aug 28, 2024
@CalvinWilkinson
Start work for issue #226
92181ee
@CalvinWilkinson CalvinWilkinson mentioned this issue Aug 28, 2024
Merged
1 task
CalvinWilkinson added a commit that referenced this issue Aug 28, 2024
@CalvinWilkinson
🚧Fix issue with pr description during initial sync (#229)
6a090e8 
* Start work for issue #226

* fix: fix admonition for pr descriptions

* docs: improve issue templates
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalvinWilkinson CalvinWilkinson

Labels
area:scripts Script related changes 🐛bug Something isn't working medium-priority Medium Priority
Projects
KD-Team
Archived in project
Milestone
v14.0.0
Development

Successfully merging a pull request may close this issue.

🚧Fix issue with pr description during initial sync KinsonDigital/Infrastructure
1 participant
@CalvinWilkinson