Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Status Time Bug #90

Merged
merged 1 commit into from
May 9, 2024
Merged

Fix Status Time Bug #90

merged 1 commit into from
May 9, 2024

Conversation

valonm
Copy link
Contributor

@valonm valonm commented May 9, 2024

Description

The Status Updater form does not default to the current time after the first time it pops up. The time in the form shows the time that the form was first accessed.

Steps to Reproduce

  1. Create a Mission or Event.
  2. Choose a Status Updater option to open the Status Updater (note the current time.)
  3. Close the form; it doesn't matter if the status change is submitted or cancelled.
  4. Wait at least 1 minute.
  5. Choose a Status Updater option to open the Status Updater.
  6. Note the time still shows whatever time it was when the form was first accessed.

Root Cause

There is a useEffect in the UpdateStatusForm component that resets the default values each time the status updater is shown. One of the setValue() calls was dropped inadvertently in the commit that updated to consistent date inputs.

The bug was introduced in Commit #85 and deployed to production in version v0.6.0.

Copy link
Contributor

@colincwilliams-kcsara colincwilliams-kcsara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the one sanity check, looks good!

@valonm valonm merged commit 037cc50 into main May 9, 2024
1 check passed
@valonm valonm deleted the status-time-bug branch May 9, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants