Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participant ETA #87

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Participant ETA #87

merged 6 commits into from
Apr 19, 2024

Conversation

valonm
Copy link
Contributor

@valonm valonm commented Mar 15, 2024

Participants in "Standby" or "SignedIn" status will see ParticipantEtaUpdater. If the user reports an ETA, then it will be displayed next to their current status in the roster tile.

  • When the Participant has not reported an ETA they will see options to quickly report a 15, 30, or 60 minute ETA, or to enter a specific time. Clicking on the "clock" button opens an inline DateTimePicker.

  • When the Participant has reported an ETA it will show the current value and has options to increment by 1 minute or to clear the value.

  • If the Participant is not in "Standby" or "SignedIn" status the ParticipantEtaUpdater is hidden and the roster tile will not display the ETA.

Screenshots

Mobile: iPhone 5/SE

image

image

image

image

image

image

@valonm
Copy link
Contributor Author

valonm commented Mar 15, 2024

Add Field for ETA to CP

@valonm
Copy link
Contributor Author

valonm commented Mar 25, 2024

Added a switch to sort responders either alphabetically or by ETA.

Previously responders were not sorted; the array is just in the order of that participants were added.

Sort Behavior

Name: Sorts the list by First Name.
ETA: Sorts the list by status then ETA with the following priority:

  1. Participants in Standby or SignedIn with an ETA; Sorted by ETA ascending
  2. Participants in Standby or SignedIn with NO ETA
  3. Participants in other Statuses

image
image

@mcosand
Copy link
Contributor

mcosand commented Mar 29, 2024

There are some elements I'd like to work on here. I don't know if it's better as a github thread, Slack conversation, or a meeting.

  • Should ETA take the bottom right corner of the card, instead of parentheticals?
  • I like the idea of the ETA control being prominent so it's easy to update, but it's prominent in areas of the app where I really want to maximize real estate (like the roster). Thinking of ways we can manage this.
  • When I finally get "sign in other user", I'm thinking about moving the status updater to a floating action button and full screen page/dialog. ie: I'm thinking about UI changes for the status updater and don't want to paint ourselves into a corner.
  • I think sort is more complicated than a switch (I'd also like to sort by status and last modified). Still trying to figure out how to do that in limited real estate.
  • (minor) I don't care about 1-minute updates to ETA. I'd start at +/-10min or 15min updates.

@valonm
Copy link
Contributor Author

valonm commented Apr 19, 2024

Per discussion with Matt, I'm going to merge as-is but the UI/UX for this feature deserves some more iteration.

@valonm valonm merged commit 6a989f8 into main Apr 19, 2024
1 check passed
@valonm valonm deleted the participant-eta branch April 19, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants