Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup effective(?) linting #48

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Setup effective(?) linting #48

merged 2 commits into from
Sep 28, 2023

Conversation

mcosand
Copy link
Contributor

@mcosand mcosand commented Sep 28, 2023

Setup more stringent linting rules, including sorting import statements

@mcosand mcosand force-pushed the refactoring branch 2 times, most recently from 4b0a78c to 4af37c1 Compare September 28, 2023 07:07
Setup more stringent linting rules, including sorting `import` statements
@colincwilliams-kcsara
Copy link
Contributor

When does the linter run? And do builds automatically fail if the linter fails?

My strong preference is having it run automatically with, at minimum, production builds and failing the build. I'm personally a fan of having it run with dev builds as well, but I know that's more contentious as it slows down prototype-style development.

@mcosand
Copy link
Contributor Author

mcosand commented Sep 28, 2023

Linting runs as part of the yarn lint or yarn build tasks. It shouldn't run during yarn dev, but it's recommended that your IDE know about lint rules (Visual Studio Code with the ESLint extension should work).

There's a GitHub action that should block commits to main or merging PRs with failing builds.

@mcosand mcosand merged commit 603b4ea into main Sep 28, 2023
1 check passed
@mcosand mcosand deleted the refactoring branch September 28, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants