Build camera further improvements #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Make this less ugly
TODO find better solution
Wyqer
requested changes
Oct 7, 2018
There was a problem hiding this comment.
Overall a very impressive piece of user input handling.
By looking through this code I guess this would be something which I wouldn't really enjoy doing, so it's even more impressive to see the effort in the building interface.
The "requested changes" are more questions then real change requests.
Missionframework/modules/02_build/fnc/fn_build_addToSelection.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/02_build/fnc/fn_build_addToSelection.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/02_build/fnc/fn_build_addToSelection.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/02_build/fnc/fn_build_boundingBoxPFH.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/02_build/fnc/fn_build_boundingBoxPFH.sqf
Outdated
Show resolved
Hide resolved
Missionframework/modules/02_build/fnc/fn_build_displayPlaceObject.sqf
Outdated
Show resolved
Hide resolved
|
Corrected the code according to comments. |
Wyqer
approved these changes
Oct 8, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Another big chunk of #470 was done in this PR.
Content:
Object collision detection(scraped for later)after confirmation and if there is enough resourcesTested on:
Local MP ACEDedicated MP ACE