Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player menu dialog #468

Merged
merged 20 commits into from
Aug 5, 2018
Merged

Player menu dialog #468

merged 20 commits into from
Aug 5, 2018

Conversation

Wyqer
Copy link
Member

@Wyqer Wyqer commented Aug 5, 2018

Q A
Bug fix? no
New feature? yes
Needs wipe? no
Fixed issues #416

Description:

Provides all players a player menu to adjust some local settings.
Rework of the "Extended Options" from the old framework.

Content:

  • Player menu dialog
  • Show KP Ranks information, when mod is loaded
  • Group Management
  • Individual view distances for "on foot", "in ground vehicle" and "in air vehicle"
  • Set Terrain Grid
  • Auto 3rd Person function
  • Disable annoying AI radio chatter
  • Adjust sound volume when in vehicle (helicopters can be loud)

Tested on:

  • Local MP Vanilla
  • Local MP ACE
  • Dedicated MP Vanilla
  • Dedicated MP ACE

Wyqer added 20 commits August 3, 2018 12:12
@Wyqer
Renamed Module
55642b0 
So it fits the naming of the "admin menu"
@Wyqer
Updated KP GUI system
0aed086
@Wyqer
Redeploy dialog adjustment
14ce332
@Wyqer
Updated KP GUI and redeploy dialog
a68766e
@Wyqer
Typos and text adjustments
d1f32db
@Wyqer
Removed BI Group System
ee9d2ed
@Wyqer
Fixed missing intro menu when intro texts disabled
26ef97c
@Wyqer
Player menu functions and globals
805e4ab
@Wyqer
Updated stringtable with player menu dialog strings
56c71e3
@Wyqer
Player menu function files
5a702fc
@Wyqer
Player Menu Dialog define
400072e
@Wyqer
KP Ranks support for player menu
1764133
@Wyqer
Action and module init for player menu
967deb8
@Wyqer
Ignore list update
6ffd47e
@Wyqer
Typo
875679f
@Wyqer
Small admin menu format tweaks
219ad03
@Wyqer
Last update state admin dialog
538fba3
@Wyqer
Tooltip for in vehicle volume concerning ACE
b7b1fd2
@Wyqer
Action ID adjustments
936360e 
My suggestion is, we start at -800 with the ActionIDs to sort our actions.
In that range we shouldn't interfere with other mods/scripts.
@Wyqer
Small join group refresh delay
36bf53c 
Otherwise the list gets refreshed before the player really switched the group.
@Wyqer Wyqer added the review/QA label Aug 5, 2018
@Wyqer Wyqer added this to the Sprint 4 milestone Aug 5, 2018
@Wyqer Wyqer requested a review from veteran29 August 5, 2018 10:35
veteran29
veteran29 approved these changes Aug 5, 2018
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Wyqer Wyqer merged commit 63f0f4b into v0.97S4 Aug 5, 2018
@Wyqer Wyqer deleted the v0.97S4-416 branch August 5, 2018 11:15
@Wyqer Wyqer added done and removed review/QA labels Aug 5, 2018
@Wyqer Wyqer changed the title V0.97 s4 416 Player menu dialog Aug 6, 2018
@Wyqer Wyqer mentioned this pull request Aug 6, 2018
Closed
@Wyqer Wyqer mentioned this pull request Aug 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.
2 participants
@Wyqer @veteran29