Skip to content

Commit

Permalink
Merge pull request #29 from Ki-Insurance/revert-25-dug-348-fix-ui
Browse files Browse the repository at this point in the history
Revert "DUG-348: fix for UI and seamless upgrade of on-demand features"
  • Loading branch information
arek-xeb authored Jun 21, 2024
2 parents 2ca9f3c + f9a6ba6 commit 788b5d4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion sdk/python/feast/on_demand_feature_view.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def __init__( # noqa: C901
)

self.mode = mode.lower()
self.mode = "pandas" if not self.mode else self.mode

if self.mode not in {"python", "pandas", "substrait"}:
raise ValueError(
f"Unknown mode {self.mode}. OnDemandFeatureView only supports python or pandas UDFs and substrait."
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/ui_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def shutdown_event():

async_refresh()

ui_dir_ref = importlib_resources.files(__spec__.parent) / "ui/build/" # type: ignore[name-defined]
ui_dir_ref = importlib_resources.files(__name__) / "ui/build/"
with importlib_resources.as_file(ui_dir_ref) as ui_dir:
# Initialize with the projects-list.json file
with ui_dir.joinpath("projects-list.json").open(mode="w") as f:
Expand Down

0 comments on commit 788b5d4

Please sign in to comment.