Merge pull request #24 from Ki-Insurance/revert-metadata-changes

Revert metadata changes
Ki-Insurance · Jun 14, 2024 · 47d85ad · 47d85ad
2 parents 86268e3 + fdc598f
commit 47d85ad
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/protos/feast/core/FeatureService.proto b/protos/feast/core/FeatureService.proto
@@ -38,9 +38,6 @@ message FeatureServiceSpec {
 
   // (optional) if provided logging will be enabled for this feature service.
   LoggingConfig logging_config = 7;
-
-  // Hidden User defined metadata
-  map<string,string> metadata = 8;
 }
 
 

diff --git a/sdk/python/feast/feature_service.py b/sdk/python/feast/feature_service.py
@@ -1,5 +1,5 @@
 from datetime import datetime
-from typing import Any, Dict, List, Optional, Union
+from typing import Dict, List, Optional, Union
 
 from google.protobuf.json_format import MessageToJson
 from typeguard import typechecked
@@ -48,7 +48,6 @@ class FeatureService:
     created_timestamp: Optional[datetime] = None
     last_updated_timestamp: Optional[datetime] = None
     logging_config: Optional[LoggingConfig] = None
-    metadata: Optional[Dict[str, Any]] = None
 
     def __init__(
         self,
@@ -59,7 +58,6 @@ def __init__(
         description: str = "",
         owner: str = "",
         logging_config: Optional[LoggingConfig] = None,
-        metadata: Optional[Dict[str, Any]] = None,
     ):
         """
         Creates a FeatureService object.
@@ -82,7 +80,6 @@ def __init__(
         self.created_timestamp = None
         self.last_updated_timestamp = None
         self.logging_config = logging_config
-        self.metadata = metadata
         for feature_grouping in self._features:
             if isinstance(feature_grouping, BaseFeatureView):
                 self.feature_view_projections.append(feature_grouping.projection)
@@ -203,7 +200,6 @@ def from_proto(cls, feature_service_proto: FeatureServiceProto):
             logging_config=LoggingConfig.from_proto(
                 feature_service_proto.spec.logging_config
             ),
-            metadata=dict(feature_service_proto.spec.metadata),
         )
         fs.feature_view_projections.extend(
             [
@@ -242,12 +238,11 @@ def to_proto(self) -> FeatureServiceProto:
                 projection.to_proto() for projection in self.feature_view_projections
             ],
             tags=self.tags,
-            metadata=self.metadata,
             description=self.description,
             owner=self.owner,
-            logging_config=(
-                self.logging_config.to_proto() if self.logging_config else None
-            ),
+            logging_config=self.logging_config.to_proto()
+            if self.logging_config
+            else None,
         )
 
         return FeatureServiceProto(spec=spec, meta=meta)