HLSL: Possibility to represent variable in binary form #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcady-lunarg
requested changes
Jul 12, 2023
There was a problem hiding this comment.
Looks okay overall, aside from a couple issues mentioned on specific lines, and one major one: this also adds support for binary literals to GLSL, which is not actually a thing that GLSL supports. You need to add a check to make sure that we're not compiling GLSL and to bail out early in that case. I would also like to see tests for the error cases here, both the "literal too big/too long" error messages and that this doesn't work with GLSL. There should be existing "negative" test files to which you can add some new cases.
Dawid-Lorenz-Mobica
force-pushed
the
hlsl_binary_representation
branch
from
39e753a to
6cd56bf
Compare
arcady-lunarg
requested changes
Jul 17, 2023
The change fixes the issue 3089
Dawid-Lorenz-Mobica
force-pushed
the
hlsl_binary_representation
branch
from
6cd56bf to
af98717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issues: #3089