removed duplicate (1 - f0) in implementation notes #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proog128
approved these changes
Sep 6, 2021
|
This PR addresses this issue: #1945 |
|
@lexaknyazev What is the cutoff for getting fixes like this copied into |
|
Ping for merge, now that this has been discussed on the call? |
emackey
added a commit
that referenced
this pull request
Sep 13, 2021
emackey
added a commit
that referenced
this pull request
Sep 13, 2021
UX3D-haertl
added a commit
to KhronosGroup/glTF-Sample-Viewer
that referenced
this pull request
Nov 30, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WestLangley noticed that for our suggested implementation, if you plug in a pure dielectric material at normal incidence, our equations reduce to
f_diffuse = (1 / pi) * (1 - f0)^2 * baseColor, which seems to be an error, as the energy-conservation term(1 - f0)is double-counted. I believe this is the right fix, but would appreciate more eyes on it.