Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skins data validation #58

Closed
7 tasks
lexaknyazev opened this issue Dec 15, 2017 · 2 comments · Fixed by #124
Closed
7 tasks

Skins data validation #58

lexaknyazev opened this issue Dec 15, 2017 · 2 comments · Fixed by #124
Assignees
Milestone

Comments

@lexaknyazev
Copy link
Member

lexaknyazev commented Dec 15, 2017

From the offline discussion, all skinning-related checks:

Scene Description Issues

  • Joints must have one or more common roots.
  • skeleton property, if used, must point to a common root.
  • When a node with a skinned mesh belongs to a scene, the joint tree must be available in the same scene.
  • Local and parent transforms on a node with a skinned mesh are ignored.

Data Issues:

  • IBM matrices don't have to be TRS-decomposable.
  • Joint indices must be valid (zeros allowed for zero-weight influences).
  • Linear sum of weights per vertex is 1.0 (across all influences).
@lexaknyazev lexaknyazev added this to the 2.0 milestone Dec 15, 2017
@lexaknyazev lexaknyazev changed the title Joints indices validation Skins data validation Mar 28, 2018
@lexaknyazev lexaknyazev self-assigned this Mar 28, 2018
@lexaknyazev
Copy link
Member Author

Implement KhronosGroup/glTF#1352.

@donmccurdy
Copy link
Contributor

Order of weights when an asset uses more than 4 influences.

From latest discussions, the validator probably does not need to verify order of weights, but should raise a warning or hint when more than 4 influences are used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants