-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add quantized versions of a few models #247
Conversation
I've included Avocado and Lantern as requested by @emackey, and also added CesiumMan (it's a skinned model) and AnimatedMorphCube (it's a model with position/normal/tangent morph targets) as well so that we have a full coverage for this extension in terms of elements that may be quantized. All 4 models render and validate without errors with https://gltf-viewer.donmccurdy.com/. The CesiumMan model generates 2 warnings due to the skinned mesh being parented to a non-root node, but it doesn't look like this repository in general is warning free. It looks like this can only be merged after the validator version used in this repository is bumped to the most recent one that supports KHR_mesh_quantization though. |
Original Maybe choose another skinned model for this PR to merge it sooner? |
Ah, I forgot about this. gltfpack renormalizes vertex influences - the model still looks fine upon visual inspection. I could choose a different model, but the model this PR adds passes validation (with a recent validator). |
Following the discussion from the linked comment, it seems that besides fixing weights, the original model will be facing different direction. This means that the quantized version will have to be regenerated to keep it aligned. Up to @emackey what to merge first. |
Replaced CesiumMan with Monster for now - let me know if we'd rather merge CesiumMan or some other model instead. |
As listed in #245 (comment), all five skinned sample models from this repo have ignored transforms in their node graphs. Three of them ( @emackey |
I think for now we should leave the skinned meshes off of this PR, at least until after #245 is settled and merged. That said, if we can resolve #245 (comment), perhaps that issue could come in before this one, in which case we could include skinned quantized models. |
Added AnimatedMorphCube, Avocado and Lantern, processed using gltfpack 0.13 to produce examples of KHR_mesh_quantization Each model was generated using gltfpack -i inputfile -o outputfile and then reformatting the output file using a JSON prettifier since gltfpack produces minified JSON by default.
Sounds good! Updated the PR to remove skinned models. We can always add them later. |
@zeux Thanks for this PR. Also can you throw in that Duck model? Thanks! |
Note that all these models are simply generated with |
Added Duck to the PR. And yeah if we ever need more models I'm happy to convert them, this is just using |
@emackey @donmccurdy |
Added AnimatedMorphCube, Avocado, CesiumMan and Lantern, processed using
gltfpack 0.13 to produce examples of KHR_mesh_quantization
Each model was generated using
gltfpack -i inputfile -o outputfile
and then reformatting the output file using a JSON prettifier since
gltfpack produces minified JSON by default.
Fixes #246