Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

New model testing out vertex colors in COLOR_0 #143

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

emackey
Copy link
Member

@emackey emackey commented Jan 8, 2018

This model tests out vertex colors in your rendering engine. If it works, it looks like this:

screenshot

Really I built this just to review CesiumGS/cesium#6089. Vertex colors are being added to Cesium, but not available in master yet as of this writing. This is the kind of thing you see when vertex colors are not implemented:

sample_fail

There are "X" marks in the "wrong" color channels, and the X's can only be hidden when the vertex colors are correctly applied.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 8, 2018

Looks cool, anyone want to review this?

@donmccurdy
Copy link
Contributor

donmccurdy commented Jan 11, 2018

Passes validation, works in three.js, and here's the ZIP version:

VertexColorTest.zip

Looks good to me.

@cx20
Copy link
Contributor

cx20 commented Jan 11, 2018

I confirmed that this model can be displayed with 3 libraries.
https://github.com/cx20/gltf-test#agi-sample-models

image
BTW, Hilo3d can display BoxVertexColors.gltf, but it does not pass the test of VertexColorTest.gltf. Is it a problem with the library?

@emackey
Copy link
Member Author

emackey commented Jan 11, 2018

Hilo3d can display BoxVertexColors.gltf, but it does not pass the test of VertexColorTest.gltf. Is it a problem with the library?

The main difference is that VertexColorTest.gltf also uses a mesh and a material without vertex colors, in the same model as one that does use vertex colors. This combination revealed a bug in Cesium's upcoming implementation which has since been fixed (but not yet released, 1.42 should have vertex color support).

I don't know if that's the same problem that Hilo3d has. The other difference is that this model is testing VEC3 colors while the other model tests VEC4 colors, that could be a factor too.

@cx20
Copy link
Contributor

cx20 commented Jan 14, 2018

I confirmed that it has been fixed by the latest version of Hilo3d.
As for Cesium, I would like to test it again when a new version comes out.

@pjcozzi
Copy link
Member

pjcozzi commented Jan 14, 2018

@cx20 I believe Cesium will be fixed in Cesium 1.42 on Feb 1.

@lilleyse can you confirm?

@lilleyse
Copy link
Contributor

Yes it will be in Cesium 1.42.

@cx20
Copy link
Contributor

cx20 commented Feb 2, 2018

I confirmed that the test model will be displayed in Cesium 1.42.
https://github.com/cx20/gltf-test#agi-sample-models
image

@pjcozzi
Copy link
Member

pjcozzi commented Feb 2, 2018

@cx20 cool, thanks for testing so promptly!

@emackey emackey merged commit 8416be1 into KhronosGroup:master Feb 21, 2018
@emackey emackey deleted the vertex-color-test branch February 21, 2018 14:53
emackey added a commit that referenced this pull request Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants