-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Skin animation models have animations and/or animation channels that do nothing #86
Comments
Related: KhronosGroup/glTF#982 (comment). |
We could do this by running through gltf-pipeline as soon as it has glTF 2.0 support. |
Some skinned models were regenerated in #245. Safe to close this? |
As of now, |
Long-standing issue in COLLADA2GLTF: KhronosGroup/COLLADA2GLTF#225 |
Untouched for almost 4 years. Can this be closed, or does it need to stay open because of the previous comment indicating an issue with COLLADA2GLTF? @lexaknyazev |
Note that channels with a constant value are not necessarily unwanted. When the application is playing back multiple animations, or transitioning from one animation to another, that track provides an important distinction between:
In other cases, a constant track may be relevant to determining the start time or duration of an animation. Probably neither of those situations was actually intended here, and it's just a COLLADA2GLTF quirk, but I just want to point out that this wouldn't be something we should rule out from the repository. I would be happy to make any of the following changes to the model, if desired:
Currently glTF Transform does (B) by default (with The size difference is 15kb → 12kb. |
This has some connection to KhronosGroup/glTF-Validator#200 |
I'm fine with no change here. As Don points out, sometimes a constant value in an animation is required, particularly in cases where the default (static) pose is not the same value. Even if that's not required here, the requested change is a micro-optimization of a small sample. Let's close it. |
For example, RiggedSimple has two animations. The first one has linear interpolations that animate all the transforms to the same values for the entire timeline. The second one has a real curve for rotation, but translation and scale also have the same values for the entire timeline.
It would be good to update the models to at least remove the no-op animations from the list.
The text was updated successfully, but these errors were encountered: