Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pot of Coals issues #95

Closed
emackey opened this issue Jan 5, 2024 · 4 comments
Closed

Pot of Coals issues #95

emackey opened this issue Jan 5, 2024 · 4 comments

Comments

@emackey
Copy link
Member

emackey commented Jan 5, 2024

  • The outer folder name should be PotOfCoals, not glTFPotOfCoals.
  • There should not be two different GLB files. One will suffice.
  • There should not be a folder named glTF-Animation.

via #90 (comment)

@echadwick-artist
Copy link
Contributor

echadwick-artist commented Feb 2, 2024

I can rename the folder and files to match.

The asset has a non-animated version because it was built for use with the Khronos glTF Viewer which doesn't support KHR_animation_pointer, KHR_materials_transmissionm, nor KHR_materials_volume.

Subsequently I made an animated version, and thought since it looked great (and we need more animation-pointer examples) perhaps we should add it to the repo. But I'm OK with removing it if needed.

echadwick-artist added a commit that referenced this issue Feb 2, 2024
Removed "glTF" prefix from all names, per issue #95.
@echadwick-artist
Copy link
Contributor

@emackey Should I make a new folder for the animated version of PotOfCoals?

@emackey
Copy link
Member Author

emackey commented Feb 21, 2024

Should I make a new folder for the animated version of PotOfCoals?

Yes, I think so. The organizational structure here still has a limitation inherited from the predecessor repository, where it doesn't make any clear allowance for several similar copies of almost the same model with various modifications applied. Often a set of variations of a model are not particularly appealing or understandable to users, but as we see here, there can be technical reasons why one user would want a different variation from another. Given the current folder structure, I think we can only present these as two separate models, such as PotOfCoals and PotOfCoalsAnimated, or similar.

Suggestions welcome.

@echadwick-artist
Copy link
Contributor

Submitting animated asset via PR #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants