update dependencies, improve robustness #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
commented
Oct 31, 2024
| } | ||
| }, | ||
| "exclude": [ | ||
| "model-viewer" |
There was a problem hiding this comment.
These two models are inexplicably, but consistently, timing out on the CI (but not locally). Increasing the protocolTimeout doesn't help - it's clear Puppeteer has simply hung. Hopefully they'll fix this bug in a future version, since it was also fine before.
| slot="renderer" | ||
| camera-controls | ||
| interaction-prompt="none"> | ||
| <model-viewer id="modelViewer" slot="renderer" camera-controls interaction-prompt="none" tone-mapping="aces"> |
There was a problem hiding this comment.
I added tone-mapping="aces" to stay consistent with the previous renders. Ideally in the future we should switch all the renderers to Khronos PBR Neutral instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling over updates I did in google/model-viewer#4898