Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Animation_SamplerType model group #534

Merged
merged 5 commits into from
Jun 10, 2019

Conversation

stevk
Copy link
Contributor

@stevk stevk commented Jun 5, 2019

Test models for animation sampler component types.
Animation_SamplerType

Fixes #533

@stevk stevk requested a review from bghgary June 5, 2019 23:36
@stevk stevk self-assigned this Jun 5, 2019
Source/ModelGroups/Animation_SamplerType.cs Outdated Show resolved Hide resolved
Source/Property.cs Outdated Show resolved Hide resolved
Source/Runtime/AnimationSampler.cs Outdated Show resolved Hide resolved
@stevk
Copy link
Contributor Author

stevk commented Jun 6, 2019

@bghgary We'll need a updated npm babylonjs package with this fix before we can generate reference screenshots for these models.

@bghgary
Copy link
Collaborator

bghgary commented Jun 7, 2019

@lexaknyazev For normalized non-float quaternions, it's impossible to get a perfectly unit quaternion. The validator is giving errors for BYTE (though not for SHORT), but I don't think we can make it any closer. See

. Also, should implementations normalize quaternions when the type is normalized non-float?

@stevk stevk merged commit e381755 into KhronosGroup:master Jun 10, 2019
@stevk stevk deleted the AnimationSamplerType branch June 10, 2019 22:06
@lexaknyazev
Copy link
Member

For normalized non-float quaternions, it's impossible to get a perfectly unit quaternion

I think there was a proposal to adjust the validation threshold so that it allows the error from ubyte quaternions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need test models for different component types for animations
3 participants