Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precision-side-effects-bug test #3192

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

lexaknyazev
Copy link
Member

When this test is run on Adreno (no repros on other vendors so far):

  • the result of the expression 0 | (int(e0 == e0) * 0x8000) somehow returns -32768 instead of 32768 despite the variable using highp precision;
  • splitting the expression along | fixes the issue (could also be observed with other operators).

@kenrussell
Copy link
Member

Thanks @lexaknyazev for the test. Looks fine.

Please file a bug on the Chromium issue tracker about this and comment here with the bug ID. We'll try to contact Qualcomm to get them to fix it.

Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenrussell kenrussell merged commit b2f27a8 into KhronosGroup:master Dec 4, 2020
@lexaknyazev lexaknyazev deleted the side-effects branch December 5, 2020 07:24
@lexaknyazev
Copy link
Member Author

Filed https://crbug.com/1155942.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants