Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layers: Header cleanup #8694

Merged
merged 1 commit into from
Oct 15, 2024
Merged

layers: Header cleanup #8694

merged 1 commit into from
Oct 15, 2024

Conversation

spencer-lunarg
Copy link
Contributor

Remove more #include headers that are just including the world everywhere

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner October 14, 2024 19:36
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 278421.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17737 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17737 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 278457.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17738 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17738 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 278495.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17739 running.

artem-lunarg
artem-lunarg reviewed Oct 14, 2024
View reviewed changes
layers/best_practices/best_practices_validation.h
@@ -25,6 +25,7 @@
#include <string>
#include <deque>
#include <chrono>
#include <set>
Copy link
Contributor

@artem-lunarg artem-lunarg Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change remove includes that are already included by some other headers? It looks like std::set is used in this file.
Please ignore!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you might have found out, the custom_containers.h wasn't hiding <set>/<map> in the #ifdef USE_ROBIN_HOOD_HASHING else check

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17739 failed.

artem-lunarg
artem-lunarg approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@artem-lunarg artem-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it's CI issue

@spencer-lunarg
Copy link
Contributor Author

CI is failing for Video test (unrelated) and tracking it here #8696

@spencer-lunarg spencer-lunarg merged commit 8911d8d into KhronosGroup:main Oct 15, 2024
20 of 21 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-headers branch October 15, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-lunarg artem-lunarg artem-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencer-lunarg @ci-tester-lunarg @artem-lunarg