Modify generation and usage of spec valid usage error strings #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-lunarg
approved these changes
Aug 7, 2018
daveh-lunarg
force-pushed
the
dave-vstats
branch
from
d587966
to
64f957c
Compare
daveh-lunarg
changed the title
|
Simple bug-fix has grown into a larger effort to update VUID error message handling. Added 'WIP' |
daveh-lunarg
force-pushed
the
dave-vstats
branch
from
64f957c
to
6ae120b
Compare
daveh-lunarg
changed the title
|
No longer WIP - please review again. |
daveh-lunarg
force-pushed
the
dave-vstats
branch
from
6ae120b
to
5b1a2a3
Compare
Improved format stripping of error text strings in vk_validation_stats script and added functionality to export a new header file that maps text VUIDs to these spec error strings. Removed lingering references to UNIQUE_VALIDATION_ERROR_CODE enums and functions that were still passing (now unused) msg_code parameters. Updated CMakeLists to avoid build errors on Win64 related to the size of the new error map. Change-Id: I1ff74c7b57ce5021271842da5419055820bd4730
daveh-lunarg
force-pushed
the
dave-vstats
branch
from
5b1a2a3
to
bce98bb
Compare
Change-Id: I6b4cf17b25b55cc6b6e4aace07b7654ccb41ce42
daveh-lunarg
force-pushed
the
dave-vstats
branch
from
bce98bb
to
967a7b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified vk_validation_stats script to allow export of a new version of
vk_validation_error_messages.h. Also improved the stripping of formatting codes to catch more cases, including one recent addition that was crashing the csv exporter.Removed some lingering references to UNIQUE_VALIDATION_ERROR_CODE enums in validation code, and updated functions that were still passing (now unused) msg_code parameters.